chrajeshbabu commented on PR #5167: URL: https://github.com/apache/hbase/pull/5167#issuecomment-1503614654
> Why change from throwing an exception to returning false? @Apache9 During the express upgrade as mentioned in comment [here]( https://issues.apache.org/jira/browse/HBASE-27698?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17699552#comment-17699552 ) there is no way to to detect the meta location in the cluster because meta location znode as well as meta wal file gets deleted when the region server stopped gracefully. So region states info for meta is not getting added which leads to init meta procedure. During the meta initialization checking whether any meta table directory present in the cluster or not, if present and proper then we are throwing the IOException saying meta need to be rebuild or meta znode should be created manually. Since this procedure persisted and cannot proceed further even with multiple restarts of master until unless manual steps of meta rebuild or znode creation and procedure store deletion are performed. All these manual steps are error prone and not required because during gra ceful shutdowns of cluster anyway meta won't be assigned to any server so allowing meta assignment during init meta procedure is correct that is what happening with my patch. Returning false because just to log that meta table directory is not deleted. [Here](https://issues.apache.org/jira/browse/HBASE-27698?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17709991#comment-17709991) I have mentioned how the upgrade going smooth with my patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
