[
https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409077#comment-13409077
]
Zhihong Ted Yu commented on HBASE-3909:
---------------------------------------
For HBaseInMemoryConfiguration.java, the license should be placed at the top of
file.
Have you seen
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompoundConfiguration.java
?
It holds multiple ImmutableConfigMap's.
Minor comment on format:
{code}
+ return true;
+ }
+ else if ("false".equals(booleanValue)) {
{code}
else is not needed. In case you want to keep it, please move it to the line
with '}'
{code}
+ LOG.debug("Found Cluster configuration in ZK. Refreshing the in
memory configuration map from ZK");
{code}
The above line is too long (> 100 chars).
It looks like ClusterConfigTracker wasn't included in the patch. Therefore it
is hard to get a global view of your design.
Can you generate a new patch for trunk and put it on the review board ?
Thanks
> Add dynamic config
> ------------------
>
> Key: HBASE-3909
> URL: https://issues.apache.org/jira/browse/HBASE-3909
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.96.0
>
> Attachments: 3909-v1.patch, 3909.v1, HBase Cluster Config
> Details.xlsx, patch-v2.patch
>
>
> I'm sure this issue exists already, at least as part of the discussion around
> making online schema edits possible, but no hard this having its own issue.
> Ted started a conversation on this topic up on dev and Todd suggested we
> lookd at how Hadoop did it over in HADOOP-7001
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
