[
https://issues.apache.org/jira/browse/HBASE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409084#comment-13409084
]
Zhihong Ted Yu commented on HBASE-3909:
---------------------------------------
I found a copy of ClusterConfigTracker in patch v1.
Please add javadoc for this class.
For hasClusterConfigAvailableInZK(), maybe a better name is
isClusterConfigAvailableInZK().
{code}
+ int configNodes = ZKUtil.getNumberOfChildren(watcher,
watcher.clusterConfigZNode);
+ byte[] data = ZKUtil.getData(watcher, watcher.clusterConfigZNode);
+ if (data != null && data.length > 0 && configNodes > 0) {
{code}
The check of configNodes > 0 should be performed before the call to
ZKUtil.getData(). If it is 0, return false directly.
{code}
+ public boolean updateClusterConfig(String configKey, String configValue) {
{code}
Consider creating a method similar to the above which accepts collection of
key/value pairs so that more than one key/value would be updated in one call.
Since I haven't seen ClusterConfigTracker in patch v2, some of the above
comments may not apply.
> Add dynamic config
> ------------------
>
> Key: HBASE-3909
> URL: https://issues.apache.org/jira/browse/HBASE-3909
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.96.0
>
> Attachments: 3909-v1.patch, 3909.v1, HBase Cluster Config
> Details.xlsx, patch-v2.patch
>
>
> I'm sure this issue exists already, at least as part of the discussion around
> making online schema edits possible, but no hard this having its own issue.
> Ted started a conversation on this topic up on dev and Todd suggested we
> lookd at how Hadoop did it over in HADOOP-7001
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
