wchevreuil commented on code in PR #5205:
URL: https://github.com/apache/hbase/pull/5205#discussion_r1179003755
##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##########
@@ -153,6 +154,7 @@ public class HttpServer implements FilterContainer {
public static final String SPNEGO_PROXYUSER_FILTER = "SpnegoProxyUserFilter";
public static final String NO_CACHE_FILTER = "NoCacheFilter";
public static final String APP_DIR = "webapps";
+ public static final String HTTP_UI_SHOW_STACKTRACE_KEY =
"hbase.ui.showStackTraces";
Review Comment:
Let's follow the naming pattern from other properties and refrain from using
came case in property names.
##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##########
@@ -652,6 +654,16 @@ private void initializeWebServer(String name, String
hostName, Configuration con
addFilterPathMapping(path, webAppContext);
}
}
+ // Check if disable stack trace property is configured
+ if (null != conf.get(HTTP_UI_SHOW_STACKTRACE_KEY, null)) {
Review Comment:
Should just do line 660 before this `if` check, then this would simply be `
if (showStackTraces) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
