wchevreuil commented on code in PR #5205:
URL: https://github.com/apache/hbase/pull/5205#discussion_r1183456928
##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##########
@@ -652,6 +654,16 @@ private void initializeWebServer(String name, String
hostName, Configuration con
addFilterPathMapping(path, webAppContext);
}
}
+ // Check if disable stack trace property is configured
+ if (null != conf.get(HTTP_UI_SHOW_STACKTRACE_KEY, null)) {
Review Comment:
what I mean is you don't need to do `conf.get(HTTP_UI_SHOW_STACKTRACE_KEY,
null)`. Just do `boolean showStackTraces =
conf.getBoolean(HTTP_UI_SHOW_STACKTRACE_KEY, false);` before this if check. If
HTTP_UI_SHOW_STACKTRACE_KEY is not set, your `showStackTraces` variable would
be set to false and you can use it in the `if` check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
