Apache9 commented on code in PR #5240:
URL: https://github.com/apache/hbase/pull/5240#discussion_r1195856872
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java:
##########
@@ -569,8 +569,17 @@ private static boolean resolveAndArchiveFile(Path
archiveDir, File currentFile,
+ " because it does not exist! Skipping and continuing on.", fnfe);
success = true;
} catch (IOException e) {
- LOG.warn("Failed to archive " + currentFile + " on try #" + i, e);
success = false;
+ LOG.warn("Failed to archive " + currentFile + " on try #" + i, e);
Review Comment:
Better add some comments about why we need this. People will be confusing
that why after the failure of a renaming, we need to delete the target file...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
