apurtell commented on code in PR #5240:
URL: https://github.com/apache/hbase/pull/5240#discussion_r1198369655
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java:
##########
@@ -569,8 +569,17 @@ private static boolean resolveAndArchiveFile(Path
archiveDir, File currentFile,
+ " because it does not exist! Skipping and continuing on.", fnfe);
success = true;
} catch (IOException e) {
- LOG.warn("Failed to archive " + currentFile + " on try #" + i, e);
success = false;
+ LOG.warn("Failed to archive " + currentFile + " on try #" + i, e);
+ try {
+ fs.delete(archiveFile, false);
+ } catch (FileNotFoundException fnfe) {
+ // This case is fine.
+ } catch (IOException ee) {
+ // Complain about other IO exceptions
+ LOG.warn("Failed to clean up from failure to archive " + currentFile
+ " on try #" + i,
+ e);
Review Comment:
Thanks for spotting that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
