wchevreuil commented on code in PR #5241:
URL: https://github.com/apache/hbase/pull/5241#discussion_r1199146155
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##########
@@ -124,7 +124,7 @@ public enum HasNext {
* You can call {@link #peek()} or {@link #next()} to get the actual {@link
Entry} if this method
* returns {@link HasNext#YES}.
*/
- public HasNext hasNext() {
+ public HasNext hasNext() throws IOException {
Review Comment:
> Then better wrap it with UncheckedIOException, or a specfic exception type
defined by us own, add more comments to explain the reason, and then handle
this exception in CatalogReplicationSourceWALReader?
That's indeed better, makes the fix much simpler, as we don't even need
additional CatalogReplicationSourceWALReader. Wrapping a FNFE in
UncheckedIOException would go all the way up to the replication endpoint, which
would then deal with it accordingly. Let me know WDYT, @Apache9 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
