sunhelly commented on code in PR #5258:
URL: https://github.com/apache/hbase/pull/5258#discussion_r1211434543


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##########
@@ -1008,9 +1008,11 @@ private RegionLocations locateRegionInMeta(TableName 
tableName, byte[] row, bool
       }
       // Query the meta region
       long pauseBase = connectionConfig.getPauseMillis();
-      takeUserRegionLock();
       final long lockStartTime = EnvironmentEdgeManager.currentTime();
+      boolean lockedUserRegion = false;
       try {
+        takeUserRegionLock();

Review Comment:
   No. Now if locking taking fails, the exception will be catched at line 1099, 
and there is pause of sleeping at line 1132 before next retry. Without this PR, 
the exception when taking lock will just throw to the outer layer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to