wchevreuil commented on code in PR #5258:
URL: https://github.com/apache/hbase/pull/5258#discussion_r1211608793
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##########
@@ -1008,9 +1008,11 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
// Query the meta region
long pauseBase = connectionConfig.getPauseMillis();
- takeUserRegionLock();
final long lockStartTime = EnvironmentEdgeManager.currentTime();
Review Comment:
So we are modifying behaviour for the `lockStartTime` (before, we were
marking the time just after acquiring the lock)? We should probably rename it,
then, because what we are recording here now is not the lock start time
anymore, but the time before locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
