sunhelly commented on code in PR #5259:
URL: https://github.com/apache/hbase/pull/5259#discussion_r1212466703
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java:
##########
@@ -76,7 +76,9 @@ public RWQueueRpcExecutor(final String name, final int
handlerCount, final int m
numWriteQueues = calcNumWriters(this.numCallQueues, callqReadShare);
writeHandlersCount = Math.max(numWriteQueues, calcNumWriters(handlerCount,
callqReadShare));
- int readQueues = calcNumReaders(this.numCallQueues, callqReadShare);
+ int readQueues = callqReadShare > 0 ?
Review Comment:
If `callqReadShare`==0, it will not be an instance of `RWQueueRpcExecutor`,
then will not call `calcNumReaders`. But `readQueues` will be 0 under other
circumstances by the origin design, when the `numCallQueues`=1 and
`numWriteQueues`=1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
