Apache9 commented on code in PR #5259:
URL: https://github.com/apache/hbase/pull/5259#discussion_r1214483134
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java:
##########
@@ -76,7 +76,9 @@ public RWQueueRpcExecutor(final String name, final int
handlerCount, final int m
numWriteQueues = calcNumWriters(this.numCallQueues, callqReadShare);
writeHandlersCount = Math.max(numWriteQueues, calcNumWriters(handlerCount,
callqReadShare));
- int readQueues = calcNumReaders(this.numCallQueues, callqReadShare);
+ int readQueues = callqReadShare > 0 ?
Review Comment:
What do you mean by "will not call calcNumReaders"? Either in the old code
or in your new code, we will always call the calcNumReaders method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
