virajjasani commented on code in PR #5293:
URL: https://github.com/apache/hbase/pull/5293#discussion_r1232567291
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemoryManager.java:
##########
@@ -317,12 +317,15 @@ private void tune() {
unblockedFlushCnt = unblockedFlushCount.getAndSet(0);
tunerContext.setUnblockedFlushCount(unblockedFlushCnt);
metricsHeapMemoryManager.updateUnblockedFlushCount(unblockedFlushCnt);
- // TODO : add support for offheap metrics
tunerContext.setCurBlockCacheUsed((float) blockCache.getCurrentSize() /
maxHeapSize);
metricsHeapMemoryManager.setCurBlockCacheSizeGauge(blockCache.getCurrentSize());
+ long globalMemstoreDataSize =
regionServerAccounting.getGlobalMemStoreDataSize();
long globalMemstoreHeapSize =
regionServerAccounting.getGlobalMemStoreHeapSize();
+ long globalMemStoreOffHeapSize =
regionServerAccounting.getGlobalMemStoreOffHeapSize();
tunerContext.setCurMemStoreUsed((float) globalMemstoreHeapSize /
maxHeapSize);
- metricsHeapMemoryManager.setCurMemStoreSizeGauge(globalMemstoreHeapSize);
Review Comment:
i was not aware either, realized these metrics exist and this is likely bug
only after Jing created this PR, i also need to do some digging here.
Thanks for pointing out `sub=Server` @bbeaudreault
FYI @jinggou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
