wForget commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1663640355
> so with this patch, even live connections will be cleaned up? > > isn't the purpose to clean the token expired connections? The connections that are being referenced will not be cleaned up. https://github.com/apache/hbase-connectors/blob/4415f28085cf6b1cd9f78cfba5bbec1eb7323839/spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/HBaseConnectionCache.scala#L122-L123 After the connection creation time exceeds maxLifeTime, it will be moved into toCloseConnectionMap, which means it will no longer be newly referenced. The connection in toCloseConnectionMap is only released after there is no reference, and will not affect the live connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
