wForget commented on PR #118:
URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1665355364

   > > > then tsNow - x._2.timestamp > timeout will never be triggered.
   > 
   > it is a wrong if your sayings is correct.
   > 
   > and in fact what it does it just same to yours, to close timeout 
connections, so you could just modify the existed one to a correct one
   
   The timeout in the current logic means that the connection will be released 
after being idle for a period of time.
   
   For a batch application that accesses hbase for a period of time and then 
performs other work, it can reuse the connection and release it when 
appropriate. But for a continuously active streaming application, we cannot 
release the connection through idle timeout but add a maximum lifetime limit.
   
   I think both parameters are needed, they are suitable for different 
scenarios.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to