Apache9 commented on code in PR #5323:
URL: https://github.com/apache/hbase/pull/5323#discussion_r1292748901
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java:
##########
@@ -24,10 +24,12 @@
@InterfaceAudience.Private
public class MetricsIO {
+ private static volatile MetricsIO instance;
private final MetricsIOSource source;
private final MetricsIOWrapper wrapper;
- public MetricsIO(MetricsIOWrapper wrapper) {
+ // visible for testing only
Review Comment:
Could use RestrictedApi to restrict the place where we can call this method.
It will cause a compilation error if called from other places in the error
prone check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
