Apache9 commented on PR #5323: URL: https://github.com/apache/hbase/pull/5323#issuecomment-1676316127
After checking the code, I think we should change the implementation for DefaultMetricsSystemInitializer? It should be called when we create HMaster or HRegionServer, not in BaseSourceImpl? Have you read the commit history about why we just add a call in the Constructor of BaseSourceImpl? It looks strange to initialize JvmMetrics with a metrics name instead of the actual process name. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
