bbeaudreault commented on code in PR #5350:
URL: https://github.com/apache/hbase/pull/5350#discussion_r1292856343


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java:
##########
@@ -87,11 +87,11 @@
 @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = 
"VO_VOLATILE_INCREMENT",
     justification = "False positive according to 
http://sourceforge.net/p/findbugs/bugs/1032/";)
 @InterfaceAudience.Private
-abstract class ServerRpcConnection implements Closeable {
+abstract class ServerRpcConnection<T extends RpcServer> implements Closeable {

Review Comment:
   Correct. I can just do the casting if you want, just felt a little nicer. 
Happy to change if desired



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to