bbeaudreault commented on code in PR #5350:
URL: https://github.com/apache/hbase/pull/5350#discussion_r1293977746
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerResponseEncoder.java:
##########
@@ -55,4 +69,33 @@ public void write(ChannelHandlerContext ctx, Object msg,
ChannelPromise promise)
ctx.write(msg, promise);
}
}
+
+ private boolean handleFatalThreshold(ChannelHandlerContext ctx) {
+ int fatalThreshold = rpcServer.getWriteBufferFatalThreshold();
Review Comment:
Not sure what you mean here. You mean instead of exposing a getter?
I want to use a getter here so that the fatal threshold can be live updated
with `update_config`. If I passed it into the NettyRpcServerResponseEncoder, it
would be static for the lifetime of a connection. I could pass in an
IntSupplier instead, but is that much better than passing in the
NettyRpcServer? I'm happy to do that if preferred
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
