bbeaudreault commented on code in PR #5350:
URL: https://github.com/apache/hbase/pull/5350#discussion_r1294817801
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##########
@@ -172,10 +306,10 @@ private ByteBufAllocator
getChannelAllocator(Configuration conf) throws IOExcept
}
}
- // will be overriden in tests
+ // will be overridden in tests
@InterfaceAudience.Private
- protected NettyRpcServerPreambleHandler
createNettyRpcServerPreambleHandler() {
- return new NettyRpcServerPreambleHandler(NettyRpcServer.this);
+ protected NettyServerRpcConnection createNettyServerRpcConnection(Channel
channel) {
Review Comment:
this change is no longer strictly necessary, but i kept it because i think
it's a cleaner way to do what we want to do. in all cases, tests were
overriding `createNettyRpcServerPreambleHandler()` just so they could inject a
special `NettyServerRpcConnection`. So it works better to simply override the
creation of the NettyServerRpcConnection directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
