bbeaudreault commented on PR #5350:
URL: https://github.com/apache/hbase/pull/5350#issuecomment-1679522998
I went through and deployed this refactor into my test cluster. Still works
as expected.
One thing to note is that when we abort the connection, the `doRespond`
change does cause a bunch of noise like this:
```
2023-08-15T19:45:07,900 [NettyRpcServer-3-6] WARN
org.apache.hadoop.hbase.util.NettyFutureUtils: IO operation failed
org.apache.hbase.thirdparty.io.netty.channel.StacklessClosedChannelException:
null
at
org.apache.hbase.thirdparty.io.netty.channel.AbstractChannel.close(ChannelPromise)(Unknown
Source) ~[hbase-shaded-netty-4.1.4.jar:?]
```
This gets spammed for all of the requests that were in flight when the
connection was closed. I wonder if I should add a `boolean verbose` argument to
`doRespond` method so that I can keep the old behavior but still override it
for the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
