[ 
https://issues.apache.org/jira/browse/HBASE-27096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761024#comment-17761024
 ] 

Nihal Jain commented on HBASE-27096:
------------------------------------

Hey [~zhangduo] I see this failure locally when running mvn spotless:verify
{code:java}
[ERROR] Failed to execute goal 
com.diffplug.spotless:spotless-maven-plugin:2.27.2:check (default-cli) on 
project hbase-operator-tools: The following files had format violations:
[ERROR]     .idea/workspace.xml
[ERROR]         @@ -141,4 +141,4 @@
[ERROR]          ····<expand·/>
[ERROR]          ····<select·/>
[ERROR]          ··</component>
[ERROR]         -</project>
[ERROR]         +</project>
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR] 
{code}
May be we add .idea to exclude list for the plugin, given .idea folder has been 
vacated in HBASE-27102?

> Exclude files which are not in source control as much as possible when 
> running spotless
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-27096
>                 URL: https://issues.apache.org/jira/browse/HBASE-27096
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, pom
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> In HBASE-27084, we added spotless:check to mvn verify stage, but the general 
> format section in spotless will include some files which are not in source 
> control, such as .idea/* or .settings/*, and then fail the 'mvn install'.
> Although usually it could be fixed by a spotless:apply call, but IDE may 
> regenerate the file and fail the build again.
> Let's add more exclude patterns to make it work better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to