bbeaudreault commented on code in PR #105: URL: https://github.com/apache/hbase-thirdparty/pull/105#discussion_r1333116831
########## hbase-shaded-netty-tcnative/pom.xml: ########## @@ -0,0 +1,145 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <!-- +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + + ON MVN COMPILE NOT WORKING + + If you wondering why 'mvn compile' does not work building HBase + (in particular, if you are doing it for the first time), instead do + 'mvn package'. If you are interested in the full story, see + https://issues.apache.org/jira/browse/HBASE-6795. + +--> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.hbase.thirdparty</groupId> + <artifactId>hbase-thirdparty</artifactId> + <version>${revision}</version> + <relativePath>..</relativePath> + </parent> + <artifactId>hbase-shaded-netty-tcnative</artifactId> + <name>Apache HBase Relocated (Shaded) netty-tcnative Libs</name> + <dependencies> + <dependency> + <groupId>io.netty</groupId> + <artifactId>netty-tcnative-boringssl-static</artifactId> Review Comment: So the idea with boringssl is that it should "just work" and be the easiest thing to drop in. If someone wanted to use the dynamically linked openssl version, they'd need to make sure they have the right dependencies installed and link them in LD_LIBRARY_PATH. I'm not sure if we can provide all of this in one module -- they both provide the same file (i.e. libnetty_tcnative_linux_x86_64.so) but with different sources. We might need to provide a hbase-shaded-netty-tcnative-boringssl and hbase-shaded-netty-tcnative-openssl. Do you think it's worth doing that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
