Apache9 commented on PR #105: URL: https://github.com/apache/hbase-thirdparty/pull/105#issuecomment-1732539889
I trid the patch locally. This is what I got locally. ``` META-INF/ META-INF/MANIFEST.MF META-INF/license/ META-INF/maven/ META-INF/maven/io.netty/ META-INF/maven/io.netty/netty-tcnative-boringssl-static/ META-INF/maven/io.netty/netty-tcnative-classes/ META-INF/maven/org.apache.hbase.thirdparty/ META-INF/maven/org.apache.hbase.thirdparty/hbase-shaded-netty-tcnative/ META-INF/native/ org/ org/apache/ org/apache/hbase/ org/apache/hbase/thirdparty/ org/apache/hbase/thirdparty/io/ org/apache/hbase/thirdparty/io/netty/ org/apache/hbase/thirdparty/io/netty/internal/ org/apache/hbase/thirdparty/io/netty/internal/tcnative/ META-INF/DEPENDENCIES META-INF/LICENSE META-INF/LICENSE.aix-netbsd.txt META-INF/LICENSE.boringssl.txt META-INF/LICENSE.mvn-wrapper.txt META-INF/LICENSE.tomcat-native.txt META-INF/LICENSE.txt META-INF/NOTICE META-INF/NOTICE.txt ``` Three problems 1. The license directory is still there? It will not break the mac build now? 2. There is a LICENSE and a LICENSE.txt, all Apache License, I think we only need one 3. There is a NOTICE and a NOTICE.txt, I think we should merge them together in NOTICE, I think [ApacheNoticeResourceTransformer](https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ApacheNoticeResourceTransformer) will help here. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
