rmdmattingly commented on code in PR #5424:
URL: https://github.com/apache/hbase/pull/5424#discussion_r1334720397
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java:
##########
@@ -57,6 +61,11 @@ public class QuotaCache implements Stoppable {
private static final Logger LOG = LoggerFactory.getLogger(QuotaCache.class);
public static final String REFRESH_CONF_KEY = "hbase.quota.refresh.period";
+
+ // defines the request attribute key which, when provided, will override the
request's username
+ // from the perspective of user quotas. This is also the default request
attribute key
+ public static final String QUOTA_USER_REQUEST_ATTRIBUTE_OVERRIDE_KEY =
+ "hbase.quota.user.override.key";
Review Comment:
Ya I acknowledge this is weird and I'm happy to follow your lead here. I
named it `hbase.quota.user.override.key` because its value is a request
attribute key that may be provided, rather than the quota user override itself.
But I agree it's kind of confusing either way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
