rmdmattingly commented on code in PR #5424:
URL: https://github.com/apache/hbase/pull/5424#discussion_r1336371479
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java:
##########
@@ -74,12 +83,15 @@ public class QuotaCache implements Stoppable {
private final ConcurrentHashMap<TableName, Double> tableMachineQuotaFactors =
new ConcurrentHashMap<>();
private final RegionServerServices rsServices;
+ private final String userOverrideRequestAttributeKey;
private QuotaRefresherChore refreshChore;
private boolean stopped = true;
public QuotaCache(final RegionServerServices rsServices) {
this.rsServices = rsServices;
+ this.userOverrideRequestAttributeKey = rsServices.getConfiguration()
+ .get(QUOTA_USER_REQUEST_ATTRIBUTE_OVERRIDE_KEY,
QUOTA_USER_REQUEST_ATTRIBUTE_OVERRIDE_KEY);
Review Comment:
I worry a bit that this could mislead people into thinking that the value of
`hbase.quota.user.override` should be their override, rather than the key to be
provided as a request attribute. Whereas I think
`hbase.quota.user.override.key` is more clearly not that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
