virajjasani commented on PR #5437: URL: https://github.com/apache/hbase/pull/5437#issuecomment-1735756935
@Apache9 the acl permissions at global and namespace level are getting messed up since resources are shared across tests. In fact, if you look at https://github.com/apache/hbase/pull/5369, this test is even passing, and only in flaky dashboard we found that the test was actually failing. The test results are not available but on https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5369/7/testReport/, i did verify before merging the PR that this test was passing. HBASE-24097 also has similar explanation and I found that we have had multiple flakies on TestSnapshotScannerHDFSAclController in the past. HBASE-24097 also had the same problem that due to sharing of mini cluster and acl among multiple tests, a particular test was failing but when run individually, it passes all the time. I don't think these tests are well written from the viewpoint of resource sharing. We should have had proper acl allocation and de-allocation with `@before` and `@after` IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
