virajjasani commented on PR #5437: URL: https://github.com/apache/hbase/pull/5437#issuecomment-1735886445
It is more like hdfs file atomic rename (instead of copy) has caused this regression because the test is fragile. We used to have atomic rename in hbase 1 already and hbase 2 somehow made it non-atomic, causing many regressions in snapshot creation in our prod env. However this test failure is not what represents issue with atomic rename, it is more about hdfs acl not working fine. So we either make test reliable with separate resource utilization or fix coproc that provides hdfs acl usage, but reverting [HBASE-28042](https://issues.apache.org/jira/browse/HBASE-28042) is not solution because it addresses totally different concern. I am just not sure about the reliability of SnapshotScannerHDFSAclController. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
