[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413569#comment-13413569
]
Elliott Clark commented on HBASE-4050:
--------------------------------------
bq.I suppose you don't need to set test size annotation on below because
annotations are not a dependency when this is built:
Correct. The hbase-hadoop-compat module has no hadoop dependency. In addition
hbase-hadoop1-compat and hbase-hadoop2-compat currently only have unit tests,
so they have the second test pass completely turned off.
bq.Does BaseMetricsSource not implement MetricsSource?
It does. I guess it's just a little too explicit. I'll fix it in the patch
first thing tomorrow morning.
bq.These need to be this accessible:
Kind of but not 100%; I'm open to either way. In hadoop 1 metrics are pretty
hard to test. Opening the maps up will make testing any classes that extend
MetricsBaseSourceImpl easier. Those classes that add functionality will need
those maps to be public for testing. However with that said this patch doesn't
have those classes in it, so if you prefer I could make them protected and
change that when needed.
bq.The stuff below where we have a static boolean and in constructor we test
something already created could be a PITA in minihbase setups? Does it have to
be static? Aren't we slinging singletons here anyways? (The singletons are ok
in minihbasecontext too?):
We are currently slinging a singleton. However when we add in more than just
replication metrics we'll have more than one BaseMetricsSourceImpl. The
DefaultMetricsSystem.initialize call can be done multiple times as long as it's
inited with the same string, however it complains quite loudly in logs.
bq.'hasInited' is name of a method that tests 'inited' variable... suggest
changing its name.
Sure. Something like defaultMetricsInited
bq.What about that jmx mess registering metrics in tests? The exception saying
metrics already registered because we have more than one daemon in the one jvm.
We still have that issue here?
We'll still have that. A little bit less spam but not completely gone.
Basically when all metrics are moved to metrics2 we'll see 4 or 5 log messages
(one per dupe of ReplicationMeticsSource et al.) rather than the massive
ammount we see now.
Maybe on test we should silience the junit messages from those classes ?
Probably a good issue to file for the metrics clean up.
bq.Do we have to have metrics2 package? Can this new stuff be in the metrics
package?
Nope. Earlier you were asking to remove it. So everything is in the metrics
namespace. That should make things a little nicer if we go the DI route,
that's being discussed on the mailing list, and someone wants to go back to the
old hadoop metrics.
bq.I thought I saw a patch where you'd renamed the properties file to what
LarsG suggested?
Nope just replied that we could. That file needs some examples and other love
(ganglia examples and examples for regionserver/rest). Seems like a good issue
for me to file after this.
I'll clean up the two javadocs tomorrow morning.
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
> Key: HBASE-4050
> URL: https://issues.apache.org/jira/browse/HBASE-4050
> Project: HBase
> Issue Type: New Feature
> Components: metrics
> Affects Versions: 0.90.4
> Environment: Java 6
> Reporter: Eric Yang
> Assignee: Alex Baranau
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch,
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050-2.patch,
> HBASE-4050-3.patch, HBASE-4050-5.patch, HBASE-4050-6.patch,
> HBASE-4050-7.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+,
> and it might get removed in future Hadoop release. Hence, HBase needs to
> revise the dependency of MetricsContext to use Metrics2 framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
