[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413121#comment-13413121
]
Elliott Clark commented on HBASE-4050:
--------------------------------------
bq.Just a question, do we still need to use "hadoop-metrics.properties" (with
out without the "2") or could we now have the proper hbase-metrics.properties
name?
We can do: hadoop-metrics2-hbase.properties
bq.Double license in new pom.
Fixed in next patch
bq.Is it right hardcoding the version in the sub module: "+
<version>0.95-SNAPSHOT</version>"
Yeah I think so. That's how common has it. removing it or using a variable
doesn't work. I think it has something to do with how maven bootstraps module
dependencies. It's lame; I'd love for a maven expert to find a better way.
bq.Can you do tests for you implementations (and have dependencies in these new
modules against the said hadoop versions?)
Sure added in the new versions. The modules already have dependencies on the
version of hadoop that they would shim, so I added some tests.
bq.Did you say you wanted ResourceFinder because you wanted to pass stuff on
construction? Where are you using constructors here?
bq.I'd be w/ Luke trying to make do with ServiceFinder if possible rather than
pull in ResourceFinder
I'm not using it yet. However the discussion above basically wanted a very
empty proof of concept. So that's what I created. The place that I see using
constructor arguments would be when I implement Histograms.
With all that said we can still just use factories, or guice like is being
discussed on the mailing list so I'm going back to ServiceLoader in the new
patch.
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
> Key: HBASE-4050
> URL: https://issues.apache.org/jira/browse/HBASE-4050
> Project: HBase
> Issue Type: New Feature
> Components: metrics
> Affects Versions: 0.90.4
> Environment: Java 6
> Reporter: Eric Yang
> Assignee: Alex Baranau
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch,
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050-2.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+,
> and it might get removed in future Hadoop release. Hence, HBase needs to
> revise the dependency of MetricsContext to use Metrics2 framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
