mihir6692 commented on PR #5470:
URL: https://github.com/apache/hbase/pull/5470#issuecomment-1771937518

   > Oh, I thought about implement this isolate in the RegionMover itself, just 
as a third operation. This way, I think you could reuse the whole original 
unload (or most of it) inside your isolate method. Then RegionMover would now 
have three operations: load/unload/isolate.
   
   
   @wchevreuil Yes, I have implemented it following commit 
https://github.com/apache/hbase/pull/5470/commits/44c6b43d11e61d6af6acb75a6b4795faeb17b03d
   
   Although there is one case which won't work with current implementation. 
While discussing offline with @virajjasani , I came to realise that It won't 
work for isolating `hbase:meta` region. 
   
   Currently I am using `MetaTableAccessor.scanByRegionEncodedName` and 
`MetaTableAccessor.getRegionLocation` to find RegionInfo and RS holding the 
region. This would not work for `hbase:meta` table.
   
   I am working on handling this case right now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to