vaijosh commented on PR #5462: URL: https://github.com/apache/hbase/pull/5462#issuecomment-1773668039
> Skimmed latest push and updated comments. Looks fine high level. > > Also one suggestion, please avoid force push and keep just 1 commit. It's very hard to review what all changed. We anyways squash and merge, so should be fine to have several commits. Thanks @NihalJain for the suggestion. I was more following "amend commit" workflow (similar to Gerrit). I was under impression that recent changes can be checked using compare link next to commit e.g. [this](https://github.com/apache/hbase/compare/3366b2a03fc49f08e22d44aad27a0d63d4e966dc..07c871e27ad8ddeac16d992d46f41a1b3ddd9344). But if this is not convenient, next time onwards I can do separate commits, and we can squash commits in the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
