vaijosh commented on PR #5462: URL: https://github.com/apache/hbase/pull/5462#issuecomment-1773689946
Hi @NihalJain Thanks a lot for approving the PR. > please check once on users field comment before commit. Yes this was valid concern. But I have simulated and tested crash scenario and checked that we don't get NPE. 1.Started Hbase in debug mode 2.Kept breakpoint in TRUNCATE_REGION_MAKE_OFFLINE block. 3.Executed truncate_region command. 4.When breakpoint was hit, killed the hbase processes using kill -9 command. 5.Kept break points in AbstractStateMachineRegionProcedure.deserializeStateData and AbstractStateMachineTableProcedure constructor. 6.Started hbase in debugger mode and attached debugger. Verified that breakpoints were hit and "region" and "user" fields were populated correctly. Also verified that truncate operation was resumed from the state and eventually it was successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
