virajjasani commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1382730988
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##########
@@ -104,6 +108,55 @@ protected void preflightChecks(MasterProcedureEnv env,
Boolean enabled) throws H
}
}
}
+ if (!reopenRegions) {
+ if (this.unmodifiedTableDescriptor == null) {
+ throw new HBaseIOException(
+ "unmodifiedTableDescriptor cannot be null when this table
modification won't reopen regions");
+ }
+ if (
+ !this.unmodifiedTableDescriptor.getTableName()
+ .equals(this.modifiedTableDescriptor.getTableName())
+ ) {
+ throw new HBaseIOException(
+ "Cannot change the table name when this modification won't " +
"reopen regions.");
+ }
+ if (
+ this.unmodifiedTableDescriptor.getColumnFamilyCount()
+ != this.modifiedTableDescriptor.getColumnFamilyCount()
+ ) {
+ throw new HBaseIOException(
+ "Cannot add or remove column families when this modification " +
"won't reopen regions.");
+ }
+ if (
+ this.unmodifiedTableDescriptor.getCoprocessorDescriptors().hashCode()
+ !=
this.modifiedTableDescriptor.getCoprocessorDescriptors().hashCode()
+ ) {
+ throw new HBaseIOException(
+ "Can not modify Coprocessor when table modification won't reopen
regions");
+ }
+ final Set<String> s = new
HashSet<>(Arrays.asList(TableDescriptorBuilder.REGION_REPLICATION,
+ TableDescriptorBuilder.REGION_MEMSTORE_REPLICATION,
RSGroupInfo.TABLE_DESC_PROP_GROUP));
+ for (String k : s) {
+ if (
+ isTablePropertyModified(this.unmodifiedTableDescriptor,
this.modifiedTableDescriptor, k)
+ ) {
+ throw new HBaseIOException(
+ "Can not modify " + k + " of a table when modification won't
reopen regions");
+ }
+ }
+ }
+ }
+
+ private boolean isTablePropertyModified(TableDescriptor oldDescriptor,
Review Comment:
nit: javadoc would be great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
