GeorryHuang commented on code in PR #2924:
URL: https://github.com/apache/hbase/pull/2924#discussion_r1386129802
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -2763,6 +2763,13 @@ protected String getDescription() {
private long modifyTable(final TableName tableName,
final TableDescriptorGetter newDescriptorGetter, final long nonceGroup,
final long nonce,
final boolean shouldCheckDescriptor) throws IOException {
+ return modifyTable(tableName, newDescriptorGetter, nonceGroup, nonce,
shouldCheckDescriptor,
Review Comment:
Now we have two methods:
` modifyTable(..[five parameters]..)`
` modifyTable(..[five parameters].., boolean reopenRegions)`
The methods 'addColumn/deleteColumn/modifyColumn' that you mentioned will
call method `modifyTable(..[five parameters]..)` directly as before. They are
not aware of the 'reopenRegions' parameter.
To make the code structure cleaner, I only changed one line in method
`modifyTable(..[five parameters]..)`, which then turns into
`modifyTable(..[five parameters].., boolean reopenRegions)`. So now, you can
see that `modifyTable(..[five parameters]..)` calls `modifyTable(..[five
parameters].., boolean reopenRegions)` with `reopenRegions=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
