bbeaudreault commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1409229182


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##########
@@ -1582,7 +1591,7 @@ default Future<Void> modifyTableAsync(TableName 
tableName, TableDescriptor td)
    * @return the result of the async modify. You can use Future.get(long, 
TimeUnit) to wait on the
    *         operation to complete
    */
-  Future<Void> modifyTableAsync(TableDescriptor td) throws IOException;
+  Future<Void> modifyTableAsync(TableDescriptor td, boolean reopenRegions) 
throws IOException;

Review Comment:
   I think we need to provide a new overload, otherwise this change is not 
compatible for existing users of this method. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to