bbeaudreault commented on code in PR #5549:
URL: https://github.com/apache/hbase/pull/5549#discussion_r1409458613
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##########
@@ -1582,7 +1591,7 @@ default Future<Void> modifyTableAsync(TableName
tableName, TableDescriptor td)
* @return the result of the async modify. You can use Future.get(long,
TimeUnit) to wait on the
* operation to complete
*/
- Future<Void> modifyTableAsync(TableDescriptor td) throws IOException;
+ Future<Void> modifyTableAsync(TableDescriptor td, boolean reopenRegions)
throws IOException;
Review Comment:
Correct. Admin, AsyncAdmin, Table, AsyncTable are public APIs, so we need to
retain backwards compatibility on them. Breaking interface changes (such as
changing a signature or deleting a method) require 2 major version releases,
with a migration path between. So if we wanted to change this signature, we
need to provide an overload and then mark the original as `@Deprecated`. The
deprecated method can't be removed until at least hbase 4.0.
I don't think we need to deprecate the original method right now since
reopenRegions is sort of an advanced usage, but just providing the context --
we do need to create an overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
