HermanCloud commented on code in PR #5550:
URL: https://github.com/apache/hbase/pull/5550#discussion_r1410128211


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcCall.java:
##########
@@ -132,4 +132,24 @@ public interface RpcCall extends RpcCallContext {
 
   /** Returns A short string format of this call without possibly lengthy 
params */
   String toShortString();
+
+  /**
+   * The queue type where the call is located. If {@link RWQueueRpcExecutor} 
is used, the queue type
+   * can be divided into read, write and scan.
+   */
+  static enum CallQueueType {

Review Comment:
   Regarding this issue, I have considered this before. There is no relevant 
context in the the method `org.apache.hadoop.hbase.ipc.RpcServer#call` to 
indicate which executor is currently used, so this information can only be 
obtained based on the incoming parameter `RpcCall call`.  I haven't found the 
suitable place for CallQueueType yet, maybe I should add a subclass? Do you 
have any suggestions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to