HermanCloud commented on code in PR #5550:
URL: https://github.com/apache/hbase/pull/5550#discussion_r1410128211
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcCall.java:
##########
@@ -132,4 +132,24 @@ public interface RpcCall extends RpcCallContext {
/** Returns A short string format of this call without possibly lengthy
params */
String toShortString();
+
+ /**
+ * The queue type where the call is located. If {@link RWQueueRpcExecutor}
is used, the queue type
+ * can be divided into read, write and scan.
+ */
+ static enum CallQueueType {
Review Comment:
Regarding this issue, I have considered this before. There is no relevant
context in the the method `org.apache.hadoop.hbase.ipc.RpcServer#call` to
indicate which executor is currently used, so this information can only be
obtained based on the incoming parameter `RpcCall call`. I thought about it
for a while, maybe adding a `None` element to the Definition of
`CallQueueType` can avoid some ambiguity? With this context, we can know what
type of queue a call is scheduled to. If `RWQueueRpcExecutor` is not used, then
it is `Default`. If the scheduler used does not use the queue, then it is
`None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
