[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416681#comment-13416681
]
Alex Baranau commented on HBASE-4050:
-------------------------------------
Looks to me that we are going to copy-paste MetricsRegistry with one addition:
allow remove metrics. Not nice.
Btw, it seems to me (if I'm not mistaken) that there's a way to remove metric
from MetricRegistry. Though it is far from nice, may be it is OK to depend on
it and file a JIRA issue to allow removals? There's a method metrics() that
returns map entries (in hadoop1) or map values (in hadoop2) which are backing
internal map of metrics and thus can be used to remove items. However:
1. searching in list for item to remove is not performance efficient. Do we
want to do it frequently? I suppose we may, but not sure
2. in general it's very bad to rely on implementation details (in future they
can return copy of values collection)
Having said that, is it better to duplicate MetricsRegistry class in our code
or use/rely on that metrics() method for now + filing JIRA to allow metrics
removals?
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
> Key: HBASE-4050
> URL: https://issues.apache.org/jira/browse/HBASE-4050
> Project: HBase
> Issue Type: New Feature
> Components: metrics
> Affects Versions: 0.90.4
> Environment: Java 6
> Reporter: Eric Yang
> Assignee: Elliott Clark
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch,
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050-2.patch,
> HBASE-4050-3.patch, HBASE-4050-5.patch, HBASE-4050-6.patch,
> HBASE-4050-7.patch, HBASE-4050-8.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+,
> and it might get removed in future Hadoop release. Hence, HBase needs to
> revise the dependency of MetricsContext to use Metrics2 framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
