NihalJain commented on code in PR #5585:
URL: https://github.com/apache/hbase/pull/5585#discussion_r1428834524
##########
hbase-shell/src/main/ruby/shell/commands/append.rb:
##########
@@ -32,18 +32,49 @@ def help
hbase> t.append 'r1', 'c1', 'value', ATTRIBUTES=>{'mykey'=>'myvalue'}
hbase> t.append 'r1', 'c1', 'value', {VISIBILITY=>'PRIVATE|SECRET'}
+
+Alternately, we can run the following commands for appending cell values for
+multiple columns at specified table/row coordinates.
+
+ hbase> append 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'},
{ATTRIBUTES=>{'mykey'=>'myvalue'}}
+ hbase> append 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'},
{VISIBILITY=>'PRIVATE|SECRET'}
+
+The same commands also can be run on a table reference.
+
+ hbase> t.append 'r1', {'c1'=>'value1', 'c2'=>'value2'},
{ATTRIBUTES=>{'mykey'=>'myvalue'}}
+ hbase> t.append 'r1', {'c1'=>'value1', 'c2'=>'value2'},
{VISIBILITY=>'PRIVATE|SECRET'}
+
EOF
end
- def command(table_name, row, column, value, args = {})
+ def command(table_name, row, column, value = value_omitted = {}, args =
args_omitted = {})
table = table(table_name)
@start_time = Time.now
- append(table, row, column, value, args)
+ # Conditional block to omit passing optional arguments explicitly
Review Comment:
improve docs here as this is very cryptic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
