NihalJain commented on code in PR #5585:
URL: https://github.com/apache/hbase/pull/5585#discussion_r1428834651


##########
hbase-shell/src/main/ruby/shell/commands/put.rb:
##########
@@ -37,16 +37,50 @@ def help
 t to table 't1', the corresponding command would be:
 
   hbase> t.put 'r1', 'c1', 'value', ts1, {ATTRIBUTES=>{'mykey'=>'myvalue'}}
+
+Alternately, we can put cell values for multiple columns at specified 
table/row and
+optionally timestamp coordinates.
+
+  hbase> put 'ns1:t1', 'r1', {'c1'=>'value1', 'c2'=>'value2'}
+  hbase> put 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'}
+  hbase> put 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'}, ts1
+  hbase> put 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'}, 
{ATTRIBUTES=>{'mykey'=>'myvalue'}}
+  hbase> put 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'}, ts1, 
{ATTRIBUTES=>{'mykey'=>'myvalue'}}
+  hbase> put 't1', 'r1', {'c1'=>'value1', 'c2'=>'value2'}, ts1, 
{VISIBILITY=>'PRIVATE|SECRET'}
+
+The same commands also can be run on a table reference.
+
+  hbase> t.put 'r1', {'c1'=>'value1', 'c2'=>'value2'}, ts1, 
{ATTRIBUTES=>{'mykey'=>'myvalue'}}
 EOF
       end
 
-      def command(table, row, column, value, timestamp = nil, args = {})
-        put table(table), row, column, value, timestamp, args
+      def command(table, row, column, value = value_omitted = {}, timestamp = 
nil, args = args_omitted = {})
+        # Conditional block to omit passing optional arguments explicitly

Review Comment:
   improve docs here as this is very cryptic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to