NihalJain commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1429026847


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##########
@@ -512,6 +527,23 @@ private void 
closeExcessReplicasIfNeeded(MasterProcedureEnv env) {
       .createUnassignProceduresForClosingExcessRegionReplicas(getTableName(), 
newReplicaCount));
   }
 
+  private void syncErasureCodingPolicy(MasterProcedureEnv env) throws 
IOException {
+    String oldPolicy = unmodifiedTableDescriptor.getErasureCodingPolicy();

Review Comment:
   The first 4 lines can be refactored into needSyncErasureCodingPolicy and 
same can be used as if condition while deciding next state in the procedure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to