bbeaudreault commented on code in PR #5579:
URL: https://github.com/apache/hbase/pull/5579#discussion_r1430569902
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -184,19 +190,13 @@ public static void sanityCheck(final Configuration c,
final TableDescriptor td)
}
// check in-memory compaction
- try {
- hcd.getInMemoryCompaction();
- } catch (IllegalArgumentException e) {
- warnOrThrowExceptionForFailure(logWarn, e.getMessage(), e);
- }
+ warnOrThrowExceptionForFailure(logWarn, hcd::getInMemoryCompaction);
Review Comment:
I added the above `warnOrThrowExceptionForFailure` overload which accepts a
ThrowingRunnable. I modified all of the below checks to use that, so just some
minor extra diff around try/catch handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
