Apache9 commented on PR #5576: URL: https://github.com/apache/hbase/pull/5576#issuecomment-1864505325
> It seems like some of the concern or confusion here is related to the generic name readVLong. If that method was used to read a _good use case_ for vlong, the performance at small byte sizes would matter. As it stands, it's only used in one _bad usecase_ the memstore ts. It's questionable whether a timestamp should be a vlong in the first place. > > Since this is only used for a timestamp use case, maybe we can move on from the small byte concerns. Would it make people feel better if we renamed the method to `readVLongTimestamp` with javadoc? @Apache9 > > (Edit: it may not be fair to call it a bad use case. What I mean is that if we care about saving bytes it feels like a timestamp could have a special encoding given the range of possible values, rather than vlong which is designed for all values) I think rename it to readVLongTimestamp is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
