bbeaudreault commented on code in PR #5576: URL: https://github.com/apache/hbase/pull/5576#discussion_r1433063478
########## hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java: ########## @@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb, final boolean includ int kvLength = (int) KeyValue.getKeyValueDataStructureSize(keyLength, valueLength, tagsLength); KeyValue keyValue = new KeyValue(bb.array(), underlyingArrayOffset, kvLength); if (includesMvccVersion) { - long mvccVersion = ByteBufferUtils.readVLong(bb); + long mvccVersion = ByteBufferUtils.readVLongTimestamp(bb); Review Comment: FWIW I don't think the mvcc version is a timestamp. Just taking a look at a random server that just opened a region (where it logs the next mvcc version), the value was `564069676` Maybe we keep readVLong and only use the new method for actual memstoreTs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org