charlesconnell commented on code in PR #5593:
URL: https://github.com/apache/hbase/pull/5593#discussion_r1441831776
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -614,11 +616,41 @@ public ConfigurationManager getConfigurationManager() {
/**
* Reload the configuration from disk.
*/
- public void updateConfiguration() {
+ public void updateConfiguration() throws IOException {
LOG.info("Reloading the configuration from disk.");
// Reload the configuration from disk.
+ preUpdateConfiguration();
conf.reloadConfiguration();
configurationManager.notifyAllObservers(conf);
+ postUpdateConfiguration();
+ }
+
+ private void preUpdateConfiguration() throws IOException {
+ if (rpcServices instanceof RSRpcServices && rpcServices.server != null) {
+ RSRpcServices rsRpcServices = (RSRpcServices) rpcServices;
+ if (rsRpcServices.server.getRegionServerCoprocessorHost() != null) {
+
rsRpcServices.server.getRegionServerCoprocessorHost().preUpdateConfiguration(conf);
Review Comment:
Good idea, this simplified the code
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -614,11 +616,41 @@ public ConfigurationManager getConfigurationManager() {
/**
* Reload the configuration from disk.
*/
- public void updateConfiguration() {
+ public void updateConfiguration() throws IOException {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
