ndimiduk commented on code in PR #5593:
URL: https://github.com/apache/hbase/pull/5593#discussion_r1441859033
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java:
##########
@@ -617,15 +616,45 @@ public ConfigurationManager getConfigurationManager() {
public void updateConfiguration() {
LOG.info("Reloading the configuration from disk.");
// Reload the configuration from disk.
+ preUpdateConfiguration();
conf.reloadConfiguration();
configurationManager.notifyAllObservers(conf);
+ postUpdateConfiguration();
+ }
+
+ private void preUpdateConfiguration() {
+ try {
+ CoprocessorHost<?, ?> coprocessorHost = getCoprocessorHost();
+ if (coprocessorHost instanceof RegionServerCoprocessorHost) {
+ ((RegionServerCoprocessorHost)
coprocessorHost).preUpdateConfiguration(conf);
+ } else if (coprocessorHost instanceof MasterCoprocessorHost) {
+ ((MasterCoprocessorHost) coprocessorHost).preUpdateConfiguration(conf);
+ }
+ } catch (IOException e) {
+ LOG.error("Error while calling coprocessor preUpdateConfiguration()", e);
Review Comment:
Instead of catching there here, can we throw them up the call chain? In
particular, this will show up in client log when the reload request comes in
via RPC. Maybe the signal handler will have to log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
