bbeaudreault commented on code in PR #5644:
URL: https://github.com/apache/hbase/pull/5644#discussion_r1464019537
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##########
@@ -413,6 +415,19 @@ private void initSSL(ChannelPipeline p, boolean
supportPlaintext)
sslHandler.setWrapDataSize(
conf.getInt(HBASE_SERVER_NETTY_TLS_WRAP_SIZE,
DEFAULT_HBASE_SERVER_NETTY_TLS_WRAP_SIZE));
+ sslHandler.handshakeFuture().addListener(future -> {
Review Comment:
@Apache9 do you think a listener is the right approach here? I'm wondering
if we should instead pass the SSLHandler into NettyServerRpcConnection, and
directly call `handler.handshakeFuture().get()` in `setupHandlers()`. That way
it's more explicit that we have the certificate on the connection prior to
handling any requests. With the listener approach, I'm not 100% sure we can
guarantee that the listener is executed in the eventLoop prior to the
channelRead0 in NettyRpcServerPreambleHandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
