Apache9 commented on code in PR #5644:
URL: https://github.com/apache/hbase/pull/5644#discussion_r1467549437
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java:
##########
@@ -413,6 +415,19 @@ private void initSSL(ChannelPipeline p, boolean
supportPlaintext)
sslHandler.setWrapDataSize(
conf.getInt(HBASE_SERVER_NETTY_TLS_WRAP_SIZE,
DEFAULT_HBASE_SERVER_NETTY_TLS_WRAP_SIZE));
+ sslHandler.handshakeFuture().addListener(future -> {
Review Comment:
https://stackoverflow.com/questions/70654915/order-of-invocation-of-listeners
Norman Maurer answered that the invocation order of listeners is the same
with adding order. And I checked the code, if there are multiple listeners
netty will call them sequentially, with the adding order. So here, since we are
the first listener(at least first in the listeners added by our code), so I
think we can guarantee that NettyRpcServerPreambleHandler.channelRead can see
the certificates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
